Conversation
Signed-off-by: grnd-alt <git@belakkaf.net>
Signed-off-by: grnd-alt <git@belakkaf.net>
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
grnd-alt
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
|
🐢 Performance warning. |
| ]; | ||
| $resp = $this->proxy->put($participantCloudId->getId(), $shareToken, $url, $params); | ||
| return $this->proxy->getOcsData($resp); | ||
| } |
There was a problem hiding this comment.
you can also add a helper function like 'reorderRemote' for the shared code, and just pass params to it.
There was a problem hiding this comment.
The code is a bit duplicated but have very different semantics for calling the endpoint for either cards or stacks so I think having a clear separation by functions makes sense? arguably getting the shareToken and cloudId etc. could be unified, but that would apply to all functions in here so I'd say not to do that here.
github-project-automation
bot
moved this from 👀 In review
to ☑️ Done
in 📝 Productivity team
2 participants
No description provided.